Mark Tyneway

Results 574 comments of Mark Tyneway

I think its worth pursuing this feature through the Rollup Improvement Process see https://github.com/ethereum/RIPs/issues/16

Thanks for looking at the spec and giving this feedback @ryanschneider! You are definitely correct that due to the current definition it is possible to have two different events that...

Is there a plan to migrate the spec to the specs repo?

This does not need to be a blocker for the betanet release, this is an optimization on top of the core functional software

Will need to update the deployment bytecode after https://github.com/ethereum-optimism/optimism/pull/16402 is merged

It would be nice if this was a configurable parameter that defaults to a sane value slightly larger than `max(expiry_window, finalization_period)`

We should deprioritize this as a must have for the betanet release. We will definitely want this as a future optimization

> packages/contracts-bedrock/src/L2/SuperchainWETH.sol Semgrep is a bit unhappy

This will need to be updated to the new interface

Going to merge this PR so that https://github.com/ethereum-optimism/optimism/pull/11256 can build on top of it, we can address the minor ABI modifications in a follow up