Tyler Weaver

Modern C++ best practices

3

Systematically go through Jason Turner's book and https://github.com/cpp-best-practices/cppbestpractices and apply modern C++ best practices to MoveIt. Related Issues: - https://github.com/ros-planning/moveit2/issues/841 - https://github.com/ros-planning/moveit2/issues/842 - https://github.com/ros-planning/moveit2/issues/843 - https://github.com/ros-planning/moveit2/issues/844 - https://github.com/ros-planning/moveit2/issues/845 - https://github.com/ros-planning/moveit2/issues/846...

Leading newlines are stripped from code segments

11

From my testing, code behaves differently from text in that it strips leading newlines. Is there a way to opt out of that behavior? Also, it seems that trailing newlines...

/rosout logging without a node?

14

I'm trying to get `/rosout` working for MoveIt 2. At the last TSC meeting, I remember it being said that there might be a way to get `/rosout` logging working...

When the key field changes, the pre-set callback could be used to declare/un-declare mapped parameters. This assumes that you can declare in the callback and that won't cause a deadlock;...

Use parameter events?

1

I should read about and understand the parameter events from ROS and update how generate_parameter_library to use them if appropriate.

This PR https://github.com/PickNikRobotics/generate_parameter_library/pull/127 found that if you build with C++20 the generated code didn't compile. To ensure we don't have that problem, I'd like to add a CI job that...

Code fails to set for user silently when there is another user with the same code

3

I'm using the Z-Wave Schlage Touchscreen Lock and I'm having trouble setting user codes. The code tries to set the code over and over again until it fails too many...

Source closed when authenticating with personal token

2

I'm not sure what I'm doing wrong here. If I create my instance like this: ```rust let octocrab = octocrab::instance(); ``` It works, and I can query github but I...

import doesn't pull, pull fails when version is a hash

5

industrial_ci is using vcstool to import from .repos or .rosinstall files into a workspace. Because we are also re-using docker images from previous runs we have the issue where the...

[WIP] Add clang-tidy test

2

This is for development of this approach to running clang-tidy as it is faster to iterate here than on moveit.