Sam Kleinman

Results 102 comments of Sam Kleinman

I think there are some interesting additional questions that we'd want to recon with: - the time to delivery on a stable, well designed service (given the smaller surface area)...

While I think we can make different decisions and value jugements about the trade-offs and values provided by different designs, but I think the advantages and disadvantages are still there....

I think it would be good to find a champion/customer that we could work with (or sponsor?) that was in favor of this work. While I mostly agree with William,...

The `main` branch includes the legacy logger (non-zerolog) and the filtering code, which means that I think this is covered by the revert, and that no further work needs to...

I think the crypto changes are potentially pretty isolated (small), offer some amount of ease, and wouldn't be disruptive to the codebase. (#6120, #5632, #6526) I think the blockchain/blocksync changes...

I sometimes run the coverage tool (manually, admittedly) when writing new code, but given the structure of our tests and the way go's coverage reporting works, I don't think that...

I think this is sort of related to the #6166: right now we have a collection of types (in the `types` package, but this may move,) and we have a...

Waiting on this till after 0.35 might make a lot of sense! I think we should also consider doing this more or less at the same time as #6616 because...

This is perhaps a different problem, and maybe kind of an absurd suggestion, but could we eliminate the event and/or send the event outside of the critical section?

We should verify a couple of facts: - peer filtering is disabled (this would interact poorly with the application mutex.) - the nodes that are having this problem are/should attempt...