terry chay comments

Results 7 comments of


                                            terry chay

Guiders to work across page loads (and other changes)

Thanks for taking a look over. I'll merge the patches back into our branch and clean up stuff so that we can track the changes to guiders somewhere between Wikimedia...

Wrong image size set when using wp_get_attachment_image() (fix)

Nice catch. Looks like WordPress core has a bug where `get_image_tag()` returns a different class than `wp_get_attachment_image()`. This shouldn't be a filter though, but patched in the plugin itself given...

Wrong image size set when using wp_get_attachment_image() (fix)

Pull request https://github.com/kylereicks/picturefill.js.wp/pull/64

plugin only working on localhost:8888

Most likely this is the culprit: https://github.com/kylereicks/picturefill.js.wp/issues/58

PHP Warning: getimagesize(): Filename cannot be empty

(I am not the plugin developer). My guess is that it's because there is a logic error in `get_unadjusted_size()`: `get_image_width_height()` is being sent a pure array, when it should be...

PHP Warning: getimagesize(): Filename cannot be empty

Pull request https://github.com/kylereicks/picturefill.js.wp/pull/66

Filtering Images in RSS Feeds

I bet you can with code that roughly resembles: https://gist.github.com/tychay/fa3490ba5eae5ec8df68 Note that I haven't tested this out as I don't use the plugin (yet).