Todd Wolfson
Todd Wolfson
While I understand the concern for maintenance, it's pretty irresponsible for something as sensitive as handling user sessions. If someone can forge someone else's user session, then they have full...
Right but it sets up a framework for everyone to reuse signers. I imagine that someone in the future might want `sha512` and this would allow for them to reuse...
That seems more restricting than the originally proposed `SESSION_SIGNER` parameter itself. The concept of having multiple built-in options and a custom `SESSION_SIGNER` override aren't mutually exclusive. How about supporting both...
Tested this on 2019 Intel MBP. Seems to work great, steps I took listed below: ```bash # Clone our repo git clone https://github.com/ytmdesktop/ytmdesktop cd ytmdesktop # Modify .git/config [remote "upstream-pr"]...
Unfortunately, my plate is much more full now than it was a few months ago. I doubt I will be able to work on this any time soon =(
I have found the root of the problem. It looks like our second phase of parsing is re-unescaping and replacing pluses with spaces: https://github.com/gabrielfalcao/HTTPretty/blob/0.8.3/httpretty/core.py#L192-L193 https://hg.python.org/cpython/file/2.7/Lib/urlparse.py#l425 https://hg.python.org/cpython/file/2.7/Lib/urlparse.py#l336
I have run out of time and will no longer be submitting a PR. I got as far as swapping `unquote` for `unquote_plus` but am having trouble with determining how...
I no longer have access to the repo but I'm guessing we either: - Worked around it in tests - Forked, partially patched, and pointed to fork in repo
No PR fix was submitted due to running out of time. Sorry, I should have clarified by no longer having access to the repo, I meant I don't recall the...
Seeing this as well on `0.15.3`, here's a very reduced JS snippet that still runs into the issue: ```js const polygonClipping = require('polygon-clipping'); const poly1 = [ [ [-89.6913437618266, 32.5917775294804],...