Todd Wolfson

Results 190 comments of Todd Wolfson

I'm fine with opening a PR but shouldn't it be under an opt-in flag? It's possible that someone uses a naming convention (e.g. camel case, non-digit-identifiers like UUID) where this...

For reference, the code of this prototype is very simple: ``` py import sublime import sublime_plugin class ExampleCommand(sublime_plugin.EventListener): def on_post_save(self, view): line = view.line(view.sel()[0]) view.add_regions('formmater-suggest', [line], 'python', 'circle', sublime.DRAW_OUTLINED) ```...

I think we're open to supporting this but I concur it will add a layer of complexity to everything. One other option aside from `noqa` is to use escaping of...

For those curious, this is a monkey-patch workaround that is equally effective: ```js // Monkey-patch over multispinner instance to prevent waiting for it to finish // https://github.com/codekirei/node-multispinner/blob/318a09dd41acd41eab90ca543f61eff25a12a860/index.js#L94-L112 multispinner.allCompleted = function...

What happens when you run the command outside of `image-diff`? ``` identify -ping -format %wx%h run-first/login-2-after.png ```

That's peculiar; ImageMagick never has a prefix and GraphicsMagick typically uses `gm` as its prefix. Can you link us to where you installed ImageMagick from? http://www.imagemagick.org/script/command-line-processing.php http://www.graphicsmagick.org/convert.html

Ah, interesting. After doing some research on the `gm` repo, this is due to name conflicts with some Windows executables. https://github.com/aheckmann/gm/issues/559 It still isn't patched in `gm` so we can't...

@mlmorg Can we add a new label named "blocked" with color `#000000` and add it to this issue? https://github.com/uber/image-diff/labels

I think there's 2 ways to interpret your response so I'll respond to both: - Why do you need an `updated_at` column on your normal model? (this is the fix...

Currently, it is a strict comparison to `0`. However, we should be able to adjust the threshold up/down based on an option: https://github.com/uber/image-diff/blob/1.0.1/lib/image-diff.js#L85 ``` js imageDiff({ actualImage: 'checkerboard.png', expectedImage: 'white.png',...