Tom Most
Tom Most
It has been deprecated, so I'll close this.
`getPage` was removed in #10295 so I'll clean up any lingering references as part of this.
https://github.com/glyph/lancer is basically this with some desktop integration features on top.
Weird, this isn't showing up at https://twisted.reviews for me. please review?
> > Weird, this isn't showing up at https://twisted.reviews for me. please review? > > It shouldn't — the end of the custom query there is `-author:@me` as it's the...
> > I don't follow... I didn't author this PR, I was looking for PRs of Adi's to review. > > Oops, I must have confused myself with multiple tabs...
It looks like #12201 addressed the perf regression here (thanks @itamarst!). The optimizations to `deprecatedModuleAttribute` seem nice-to-have, but not a blocker. please review
Thank you for the review @adiroiban!
There's another set of defaults on `KafkaCodec.encode_fetch_request()`: https://github.com/ciena/afkak/blob/b7e0a716881ff776e15843465586a4cbd942cb6c/afkak/kafkacodec.py#L361-L362
Sorry it took so long to respond here — I'm trying as best I can to get #37 in before vacation next week. I don't think that the changes to...