Tom Most

Results 66 comments of Tom Most

@rodrigc It wasn't actually possible to make this pass lint by only changing formatting before #1365 because pycodestyle-twisted had both of these warnings enabled: * W504 line break after binary...

Yes, you can return a [`Resource`](https://twistedmatrix.com/documents/current/api/twisted.web.resource.Resource.html) that streams by calling `request.write(b'...'); request.write(b'...'); request.finish()` in the usual Twisted Web way.

There is another workaround: use `twisted.trial.unittest.TestCase` instead of `SynchronousTestCase` (and let it spin the real reactor).

FWIW, I usually work around this in test suites by either: - Using a totally synchronous body producer like the [`BytesProducer` in the narrative docs](https://twistedmatrix.com/documents/current/web/howto/client.html), when all request bodies are...

That sounds reasonable to me. I can see other use cases, e.g. using the *json* keyword argument with a JSON Patch content type.

Also see #327 and https://twistedmatrix.com/trac/ticket/10177

Hey! I'm the somewhat-absentee maintainer of Treq, and also a committer on the primary Twisted project and several other sub-projects. I'd say Treq should use the same process as Twisted...

Hi @JamieSlome I've issued a security release of Treq, version 22.1.0, addressing [GHSA-fhpf-pp6p-55qc](https://github.com/twisted/treq/security/advisories/GHSA-fhpf-pp6p-55qc). There is also a Twisted release in progress to address [GHSA-92x2-jw7w-xvvx](https://github.com/twisted/twisted/security/advisories/GHSA-92x2-jw7w-xvvx) / CVE-2022-21712. The bulk of the...

@JamieSlome The fix was made in Twisted, so I don't see how to express that in your form. There hasn't been a Treq release that bumps the Twisted dependency yet...

@JamieSlome Sure, switch it to twisted/twisted.