Bernie

phone_formats: ['###-###-####'], this format is not really valid, needs to be ['200-200-0000'] where: 0 replaced by 0-9 2 replaced by 2-9 otherwise the number generated is not valid the first...

plugin:angular/recommended You guys are experts. Expected there to be a plugin:angular/recommended setup similar to other packages that would at least cover over the absolutely never do this, and warnings for...

use package.json for version information? HG no .git.

3

$ oclif-dev pack fatal: not a git repository (or any of the parent directories): .git Error: Command failed: git rev-parse --short HEAD null at makeError (~/.npm-global/lib/node_modules/@oclif/dev-cli/node_modules/execa/index.js:172:9) at Promise.all.then.arr (~/.npm-global/lib/node_modules/@oclif/dev-cli/node_modules/execa/index.js:277:16) at...

obj instanceof http.IncomingMessage hard to create tests for

2

https://github.com/caolan/forms/blob/fbb4e5dc6ff93a6e8d89480aff7e278f87403915/lib/forms.js#L71 } else if (obj instanceof http.IncomingMessage) { that line requires that you really have an instanceof http.IncomingMessage which is not really easy to create in a mock, and then...

--ignores ignores too much bug/critical

1

mkdir temp cd temp npm init -y npm i eslint@4 eslint-plugin-promise@3 david u --ignores rbn-css,eslint-plugin-promise,myotherpackage *expected* eslint-plugin-promise is not upgraded to 4 eslint is upgraded to 5 *actual* neither package...

wrong project