Wilfred Mallawa

> CI error: > > ``` > Compiling capsules v0.1.0 (/home/runner/work/tock/tock/capsules) > Compiling rv32i v0.1.0 (/home/runner/work/tock/tock/arch/rv32i) > Compiling lowrisc v0.1.0 (/home/runner/work/tock/tock/chips/lowrisc) > Compiling earlgrey v0.1.0 (/home/runner/work/tock/tock/chips/earlgrey) > Compiling components v0.1.0...

> How are we going without the boot ROM in this PR? Or is the change here just that the QEMU tests no longer exercise the boot ROM, but verilator...

> We should not use cfg features in chip crates. OT is an odd case where verilator and FPGA can differ, and we have `chip_config.rs` to contain those differences. We...

> I'm ok with some sort of `aes_bootup_delay_loops` variable in chip_config, that is set to 0 for fpga and something else for verilator. Thanks, implemented the suggested changes.

Reading through the programming guide for the hwip, it does mention that ["software must ensure that the AES unit is idle by checking STATUS.IDLE"](https://docs.opentitan.org/hw/ip/aes/doc/#programmers-guide). Even though hardware is fast enough...

Reverted the Verilator specific delays, so now the changes apply in all cases. Tested by running the aes tests on Verilator.

> What is the status of this? On the Tock side It's ready, but we are waiting on [this qemu patch series](https://patchew.org/QEMU/[email protected]/) to fix the CI failure (jumping into the...

@jon-flatley thanks for this! are you okay for me to add this as a patch to https://github.com/tock/tock/pull/3249 ?

I haven't come across this before, but those options ( `-maccumulate-outgoing-args` & `mno-red-zone`) don't seem to be specified for aarch64?

I was referring the validation of the certificate chain on the requester (locally) before even the `libspdm_set_certificate()`. So we don't even bother sending something that isn't valid to the responder....