Dennis Marttinen
Dennis Marttinen
@pmazzini could this be reviewed and merged as well? As stated in https://github.com/insomniacslk/dhcp/pull/469 this is a blocker for https://github.com/siderolabs/talos/pull/5897 and thus the release of Talos v1.2.
I've now refactored this to allow using the existing `NewInform` instead of `NewInformFromOffer` (which has been removed) for sending INFORM requests from client applications. While sending the actual request was...
I've resolved the conflicts, could you take one more look at this (now that it's cleaned up) when you have time @pmazzini?
I came up with the following solution when trying to set up the [golangci-lint GitHub Action](https://github.com/marketplace/actions/run-golangci-lint) for a monorepo: `$ cat .github/workflows/golangci-lint.yaml` ```yaml name: golangci-lint on: [push, pull_request] jobs: resolve-modules:...
There's a problem with that, the server may decide to drop the client IP from the ACK response (see `ciaddr` [here](https://www.rfc-editor.org/rfc/rfc2131#section-4.3.1)), which means that a purely ACK-based solution would not...
Indeed, didn't look at the correct row. The change to `NewRenewFromAck` is now available here: https://github.com/insomniacslk/dhcp/pull/498
Good feedback, how about this: - I've abstracted the needed ACK/NAK handling out to `TransactAckNak`, as is, from the original `RequestFromOffer`, and kept it so that `Request` needs no modifications....
Description and example updated.
If everything's good now, can you merge?
Thanks for the reminders. There's still one more PR to expose an interface we need at https://github.com/insomniacslk/dhcp/pull/470, but seems to have completely stalled. I'll try to refresh it once more...