Dennis Marttinen

Alright, inspired by @pmazzini's suggestions I present a new approach. - https://github.com/insomniacslk/dhcp/pull/469/commits/7cd86e1b80be3a3ca310b447519e887b94a2a240 adds the required functionality and a dedicated modifier for option deletion. - https://github.com/insomniacslk/dhcp/pull/469/commits/575f18f584ca106c1af28f533d245629092f6403 essentially implements `NewRenewFromOffer`, but in...

> How about making the renew a method of the lease? > > https://github.com/insomniacslk/dhcp/blob/master/dhcpv4/nclient4/lease.go#L25 This make sense. I don't have time to proto this today anymore, but will look into...

8dc422bf899950c56f65968ea86966a0e964c51d now contains the approach where `Renew` is a method of `Client` next to `Release`. This is the smallest changeset I could come up with, the architecture is not very...

I've managed to integrate `Renew` with the existing `RequestFromOffer` method. The functionality should be the same, but this approach avoids the code duplication and maintenance overhead. Will now write some...

Alright, unit tests added. This should now be ready for final review.

Review feedback assessed.

https://github.com/insomniacslk/dhcp/commit/b0e331049c1e6f7c7be239051ac993ff586c536a just moves the `Renew` function up a bit in anticipation for the next PR to avoid unnecessary merge conflicts. No functional changes were made, this should be ready now.

Seems like there are no more comments, could this be merged @pmazzini? I've submitted a follow-up changeset at https://github.com/insomniacslk/dhcp/pull/470 which would also be great to have reviewed and merged together...

@pmazzini could this be reviewed and merged? I think I have addressed all of the feedback, and don't plan on doing any more changes. This PR and https://github.com/insomniacslk/dhcp/pull/470 are really...

Yes, this PR is ready to be merged from my side. I will fix up https://github.com/insomniacslk/dhcp/pull/470 this weekend as well, apologies for the delays there as I've been quite busy...