Tommy Allen
Tommy Allen
@joeyespo Have you been able to review the changes?
Ping @joeyespo
Looks fine to me. A small nitpick: could you make the image widths the same size?
> This adds quite some overhead to the repo itself (152.0KiB, but still). I didn't notice that! Yeah that overhead is unnecessary. What I usually do is drag the images...
@rollokb I'll see how @zchee feels about adding other features provided by Jedi's API. My opinion is that I'd like to focus on asynchronous completions since the other features are...
I think we can unit test things like utility functions, cache keys, etc. It'll be difficult to test the server, though.
I think it's because a special buffer is used for the terminal and it's the best way to make sure it's gone after the terminal session is over. Here's what...
> Although - on your end, does the original file come back without any syntax highlighting? Does the highlighting change for you? I'm not seeing that. I'm using 0.1.5.
Maybe try adding this after the split? ``` vim execute 'doautocmd FileType' buf ```
Oh, that was wrong. Try it with: ``` vim execute 'doautocmd FileType' getbufvar(buf, '&filetype') ```