Thomas Van Strydonck

Yep, you're right, changing the cwd in nvim fixes the issue. Before, I was running from `~`, which triggers wrong formatting. If I cd to the basedir of the file,...

That's a nice, minimal way to implement this flattening operation :) Now we just need to think of a way to make the `retain` parameter work better

Oh, I just had a thought: I don't think this implementation works for removing `Node`s and `Voter`s as part of a batch at the same time: nodes can only be...

https://github.com/databendlabs/openraft/pull/1351#issuecomment-2773105575 I've had some more time to think about this PR just now, and what I said above isn't correct. Imagine that we have a batch as follows (with `retain...

So what to do about `retain`? I've thought about one proposal that _should_ be compatible with this PR, which Ill write out below. (I know you might not love this...

I was trying to change the `Membership` structs as little as possible in my solution above (i.e. add just a single [vec of] flag[s]). However, if explicitly adding the set...

> However, there's one important consideration: modifying the internal structure of Membership is a breaking change. I'll need to implement this in a backward-compatible way to avoid breaking existing user...

FWIW, this PR looked good to me :) Apart from the `retain` shenanigans, but those should be fixed in #1395

It was some homebrew, very basic theme, that did no more than set a couple environment variables for configuration. I investigated further and the cause seems to just be that...

Ok, thanks for the information! I use a tiling window manager, so I tend to use either the entire height of the screen or half of it. I'll have another...