Results 22 comments of Theron Voran

Hi @PepijnSenders! Thanks for the patch here, though keep in mind we can't do much with it until the CLA is signed. You may also be interested in the approach...

Hi @musmandevops when using an HCP Vault cluster with this action you shouldn't need to specify a caCertificate, since the one HCP Vault uses is already trusted by github's runner....

It looks like a lot of the failed tests are using the PassthroughBackend, so I wonder if that needs another type assertion in request_handling.go and the factory wrapped in request_handling_test.go:...

Thanks for bringing this up! This makes sense to me; I'll see about getting it worked into our release process.

This is now done. `hashicorp/vault-action@v2` should work in your workflows. We'll see about getting the readme updated too.

Yep, looks like this was solved in #299. Thanks!

Hi folks, so it turns out the k8s client used for service registration does actually reload the service account token if it encounters an error when making an API call....

Thanks for putting this up, though it looks like we updated the docs for 1.22+ in #16029, so I'll close this for now.