vault-action icon indicating copy to clipboard operation
vault-action copied to clipboard

[BUG] Last version doesn't refer to a major tag.

Open FrancoisXavierNoe opened this issue 3 years ago • 2 comments

Describe the bug Last version (v2.3.1) doesn't refer to a major tag (v2).

To Reproduce

    steps:
      - uses: hashicorp/vault-action@v2
        ...

Expected behavior Get the last version v2.3.1 when uses hashicorp/vault-action@v2.

Log Output Error: Unable to resolve action hashicorp/vault-action@v2, unable to find version v2

Additional context Hi there, Is it possible to create/update a major tag (e.g. v2) when you create a tag for minor or patch version (e.g. v2.3.1) ?

Below an example: image

FrancoisXavierNoe avatar Oct 08 '21 10:10 FrancoisXavierNoe

Here a link to the documentation where GitHub recommends using major version tags: https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management

netsandbox avatar May 13 '22 17:05 netsandbox

I see this documentation, and GitHub write :

Move the major version tag (such as v1, v2) to point to the Git ref of the current release.

FrancoisXavierNoe avatar May 16 '22 07:05 FrancoisXavierNoe

Thanks for bringing this up! This makes sense to me; I'll see about getting it worked into our release process.

tvoran avatar Oct 25 '22 23:10 tvoran

This is now done. hashicorp/vault-action@v2 should work in your workflows. We'll see about getting the readme updated too.

tvoran avatar Oct 26 '22 18:10 tvoran

@tvoran sadly this is not fixed. v2.4.3 was released yesterday, but tag v2 still points to v2.4.2. Please update your release process.

netsandbox avatar Nov 10 '22 06:11 netsandbox

@netsandbox - Sorry about that! We just updated the v2 tag to point to v2.4.3.

austingebauer avatar Nov 10 '22 18:11 austingebauer