Tim van Dijen

Results 480 comments of Tim van Dijen

This is a tough one.. It's not required to send a RelayState, so your upstream IDP is wrong here.. I also think it doesn't make sense to pass the RelayState...

May I assume you're using the HTTP-Redirect binding for the SAML Requests? Both for SP > Proxy as for Proxy > IDP?

If we do this, we may want to consider using `symfony/cache` to simplify our code for different caching-backends.

Since attribute translations can be added to `dictionaries/attributes.definition.json` and `dictionaries/attributes.translation.json`, I think this one can be closed?

I don't think we should modify these files.. Anyone can use `attributes.extradictionary` or manually add them to the existing dictionary.. I don't think anyone has missed them since this issue...

I don't think you need the settings in the `metadata.sources` array at all.. They are only needed to _override_ the `database.`-settings. The problem you have had is that you jumped...

I think this is a duplicate of https://github.com/simplesamlphp/simplesamlphp/issues/1054

We were discussing this at the hackathon 2019/3.. There is a tool available @ https://github.com/simplesamlphp/dictionaryconverter For 1.18 or 2.0 we have to re-generate the .po-files

Support was added to the library in https://github.com/simplesamlphp/saml2/pull/232 . It is targeted for saml2 v5, which is targeted for SSP 2.0.. A backport to 1.19 / saml2 v4 doesn't seem...

What's holding you back from creating an `EnhancedUserPassBase`? A few thoughts on what I've just read: - There are classes inheriting from `UserPassBase` that would not be able to implement...