Thomas von Deyen

Results 253 comments of Thomas von Deyen

> But I wonder why I have this issue and you or others don't... What's the difference in the setup? If you use a CDN and get the images from...

Yeah. A very outdated thing to do. With HTTP2 and modern browsers you do not need to load assets from another host. This was when browsers weren't able to load...

What I do not like about using tools like this is that it gives the impression that the tests are stable (they just take longer, what is hard to track...

@dbwinger would you mind to update commit message now that we changed the implementation?

Installer spec will be fixed by backport PR https://github.com/solidusio/solidus_starter_frontend/pull/372

Maybe related to Rails 7.1? https://edgeguides.rubyonrails.org/7_1_release_notes.html#add-rails-application-deprecators

Solidus v4.3 is not compatible with Rails 7.2. You need to use the released version of v4.4.2 from Rubygems. Just install it via bundler ``` bundle add solidus --version=4.4.2 ```

It looks like the database already includes the active storage tables. Do you have a vanilla rails app or is this an existing one? But actually the solidus installer should...

> [@tvdeyen](https://github.com/tvdeyen) When I find a bug do we reopen an issue or create a new one? create a new one referencing the old one.

fails because https://github.com/solidusio/solidus/pull/5812 has not been backported to v4.3