AlchemyCMS
Load site default language ID into session unless the one in session …
…is associated with the current site.
What is this pull request for?
If at least one site has multiple languages, after the language is switched in the admin/pages view, the language ID is saved to session, and switching to another site does not change the language in session, which causes that language's pages to continue to be shown.
Closes #2956
This should be backported at least to 7.1.
Checklist
- [x] I have followed Pull Request guidelines
- [x] I have added a detailed description into each commit message
- [x] I have added tests to cover this change
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.02%. Comparing base (
72973ad) to head (d6de41a). Report is 17 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2957 +/- ##
==========================================
+ Coverage 96.00% 96.02% +0.01%
==========================================
Files 232 233 +1
Lines 6282 6309 +27
==========================================
+ Hits 6031 6058 +27
Misses 251 251
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@tvdeyen I don't mean to rush you but just wanted to make sure you saw this PR. I wondered if the codeclimate error caused you not to get alerted. I can't tell what the problem is there.
@dbwinger would you mind to update commit message now that we changed the implementation?
@dbwinger would you mind to update commit message now that we changed the implementation?
Done.
💚 All backports created successfully
| Status | Branch | Result |
|---|---|---|
| ✅ | 7.1-stable |  |
| ✅ | 7.2-stable |  |
Questions ?
Please refer to the Backport tool documentation and see the Github Action logs for details
