ldmx-sw icon indicating copy to clipboard operation
ldmx-sw copied to clipboard

Add pass name to every getCollection() occurance

Open tvami opened this issue 9 months ago • 1 comments

Is your feature request related to a problem? Please describe.

With the resim sample there are 2 SPs and none of the code is consuming pass names for the SPs. Which made me look where else we are missing the pass names.

Describe the solution you'd like

Add pass name to every occurance of getCollection() https://github.com/search?q=repo%3ALDMX-Software%2Fldmx-sw%20getCollection&type=code

Describe alternatives you've considered

None, we enforce this for any future code anyway.

Additional context

Missing momentum analysis with the reSimmed ecalPN sample

tvami avatar Mar 06 '25 04:03 tvami

After this issues is resolved, I propose we change https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Framework/include/Framework/Event.h#L390

      const std::string &passName = "") const {

to

      const std::string &passName) const {

so people will be forced to have a pass name passed

tvami avatar Mar 12 '25 16:03 tvami

This is resolved in https://github.com/LDMX-Software/ldmx-sw/pull/1708

tvami avatar May 21 '25 16:05 tvami