Tommi Vainikainen

Results 22 comments of Tommi Vainikainen

This is missing integration tests for the new code. The integration tests for this feature need quite some work due setting up Kafka with SASL authorization to run the test...

Would you mind to share those Helm charts for public usage? In any case the container image of Karapace you've running needs some environment variables to run correctly. The documentation...

> It did work on my kind cluster with kafka autheticated. Do I understand you correctly here that with changes in Helm charts you were able to get Karapace running...

I did read some code here. The problem here is caused by session constructor adding `generate` method to given `store` in [/index.js](https://github.com/expressjs/session/blob/master/index.js#L157) When shared store is given as parameter to...

@joewagner Probably I'll do that, because it seems to be easier fix for us. Having two redis connections parallel doesn't cost that much. However in this case express-session does not...

> IMHO we don't need this extra complexity. We worked hard to get to a point were our image tagging give users the most flexibility. Users who want stability should...

Also support for addr:flats would be nice. E.g. searching for "Pietolankatu 59 A 1, Järvenpää, Finland", I would expect to find https://www.openstreetmap.org/node/2222227520 which is a node with addr:flats=1 in a...

For now we have been using * Merge Commits but with exception * Squash merge if external contributions has convoluted commit history with without helpful commit messages as the exception...

You need to add `registry_authfile` setting to Karapace config json. The details of the configuration are in the chapter Authentication and authorization of Karapace Schema Registry REST API https://github.com/aiven/karapace#authentication-and-authorization-of-karapace-schema-registry-rest-api Hope...

You're correct here. If `KARAPACE_REGISTRY_AUTHFILE` or `registry_authfile` in karapace config json is set, then all schema registry requests are authorized using those credentials and permissions. However please note that REST...