Javed Khan

Results 60 comments of Javed Khan

@OrfeasLitos only minor nit. Please use standard commit messages e.g: spvnode: implement sendTX and relay; emit "tx" test: add node sendTX test case for "tx" event Apologies for having this...

Also, either squash the commits or move `spvnode-test.js` to the commit last commit. Because, without the fix, the spv test will fail and break the build at that commit.

Somewhat related: `TypeError: Cannot read property 'kill' of undefined` when `bcoin` runs out of disk space and dies with the above error. Full log: https://gist.github.com/tuxcanfly/870bad0b9e5a91e26ed697cb68b4f225

Yeah, agreed with this being a part of `block-test.js`.

OK, created issues for whatever we're missing. The remaining unchecked items are issues specific to bitcoin-abc.

> @tuxcanfly or @nodar-chkuaselidze can you guys check the Travis CI script is correct? > I am experiencing same output as Rojii -- tests pass locally: > `npm run test`...

> Please be sure to fix the linting errors and its important to make the tests pass in CI. Have you tried syncing the node against the upgraded testnet? Looks...

> @tuxcanfly Tests passed locally for me after switching to `node 10.2`, I saw that version in the CI log As it happens, when I switched to `10.2` I still...

Hmm, it could be that `npm install istanbul codecov` etc step is changing the `package.json` file, so it's checksum fails to match during the save cache phase? https://support.circleci.com/hc/en-us/articles/360004632473-No-Cache-Found-and-Skipping-Cache-Generation ``` If...