tutufool

working with sbt-aspectj

1

Hi, I'm using sbt-aspectj plugin to do runtime weaving for my code. The config for aspectj plugin is something like: lazy val aspectJSettings = aspectjSettings ++ Seq( aspectjVersion := Dependencies.aspectjVersion,...

Shall we allow nullable return value when no SpanContext extracted?

8

https://github.com/opentracing/opentracing-java/blob/578d4e74d9b16c18268717e537000a88d7e6779c/opentracing-api/src/main/java/io/opentracing/Tracer.java#L95 You may check this issue for details: https://github.com/openzipkin/brave-opentracing/issues/49 Thanks Leon

call finish() on a finished span

4

Hi, I'm curious about expected behaviors of below code: ``` .... span.finish(); //should below be ignored? span.setTag("k1", "v1"); span.finish(); ``` I saw the javadoc mentioned finish() should be the last...

Hi, I got below exception when using XML codec: java.lang.RuntimeException: java.util.NoSuchElementException at protobuf.codec.AbstractCodec.toMessage(AbstractCodec.java:74) at protobuf.codec.AbstractCodec.toMessage(AbstractCodec.java:88) at protobuf.codec.AbstractCodec.toMessage(AbstractCodec.java:83) ... ... Caused by: java.util.NoSuchElementException at com.ctc.wstx.sr.BasicStreamReader.next(BasicStreamReader.java:1114) at protobuf.codec.xml.XmlReader.parseElement(XmlReader.java:52) at protobuf.codec.xml.XmlReader.parse(XmlReader.java:41) at protobuf.codec.xml.XmlCodec.readFromStream(XmlCodec.java:56)...

Hi, I got some exception when trying to using xml codec: Caused by: com.ctc.wstx.exc.WstxIOException: Invalid null character in text to output at com.ctc.wstx.sw.BaseStreamWriter.writeCharacters(BaseStreamWriter.java:488) at protobuf.codec.xml.XmlWriter.writeFieldValue(XmlWriter.java:68) at protobuf.codec.xml.XmlWriter.writeXml(XmlWriter.java:47) at protobuf.codec.xml.XmlCodec.writeToStream(XmlCodec.java:69) ......

RequestEvent for RequestEventListener might lost request attributes for async flow

5

As you can see from above screen shot: Thread A: request will be recycled ( attributes of request will be cleared) Thread B: try to get request attribute from container...