tutububug

ok, thank you. I had forked repository of client-go to modify method signature. -------- 原始邮件 -------- 发件人： iosmanthus ***@***.***> 日期： 2022年2月22日周二 15:58 收件人： tikv/client-go ***@***.***> 抄送： tutububug ***@***.***>, Mention ***@***.***>...

> Thank you for your contribution! Maybe you need to add a command parser to use the data structure with actual command like redis. Yes, I will give the commit...

@PragmaTwice I create a PR(https://github.com/apache/kvrocks-website/pull/207) for describe hyperloglog storage format.

> Regarding your design, I have some questions: > > 1. Based on the current design, typically one Redis key will introduce a maximum of 16384 RocksDB keys (registers). Each...

@mapleFU @PragmaTwice Thank you for carefully code review. Since the code for the algorithm part comes from redis, some function arguments and comments need to be adjusted. Regarding optimizing key...

@mapleFU @PragmaTwice The code refactoring is ready for review, and the storage format description is sorted out at https://github.com/apache/kvrocks-website/pull/207/files. Please take a look if have time. cc @git-hulk @torwig

> Sure, @tutububug can help to fix the lint error while you're free: https://github.com/apache/kvrocks/actions/runs/8538011240/job/23657605010?pr=2142#step:7:1368 Strange, there is no such warning in my branch(https://github.com/tutububug/incubator-kvrocks/pull/6). I triggered the action again to check.

> @tutububug you can pull the unstable into this branch and have a try. fixed

> This looks much better than previous version. The remaining are mostly code-style problem fixed.

to fix issue #371 .