naive-ui icon indicating copy to clipboard operation
naive-ui copied to clipboard

docs(select): placeholder default is `undefined`

Open OrbisK opened this issue 1 year ago • 4 comments

placeholder should default to undefined. Like input docs.

whould be confusing for other languages.

OrbisK avatar Aug 30 '22 09:08 OrbisK

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
naive-ui ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 9:32AM (UTC)

vercel[bot] avatar Aug 30 '22 09:08 vercel[bot]

image There is a problem with this PR.

XieZongChen avatar Aug 30 '22 13:08 XieZongChen

If so I think may components should be modified. Maybe we can specify it's related with locale.

07akioni avatar Aug 31 '22 16:08 07akioni

Maybe we should link the default to i18n. So we don't specify the default as kinda hard coded.

OrbisK avatar Sep 22 '22 13:09 OrbisK

added i18n in 09be4975920945817842ecebc13104cbfdf5956f

07akioni avatar Dec 24 '22 11:12 07akioni