naive-ui icon indicating copy to clipboard operation
naive-ui copied to clipboard

feat(data-table): make expand content sticky by default

Open equt opened this issue 2 years ago • 3 comments

close #3485

equt avatar Aug 11 '22 07:08 equt

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
naive-ui ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 1:06AM (UTC)

vercel[bot] avatar Aug 11 '22 07:08 vercel[bot]

Codecov Report

Merging #3488 (23ecd62) into main (1ed0aec) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3488      +/-   ##
==========================================
- Coverage   63.03%   63.03%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       21877    21878       +1     
  Branches     5695     5696       +1     
==========================================
  Hits        13790    13790              
  Misses       6601     6601              
- Partials     1486     1487       +1     
Impacted Files Coverage Δ
src/data-table/src/TableParts/Body.tsx 62.31% <0.00%> (-0.23%) :arrow_down:
src/data-table/src/styles/index.cssr.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 11 '22 08:08 codecov[bot]

补一下 changelog

Sepush avatar Aug 11 '22 12:08 Sepush

要不要加个什么 expand-sticky 之类的 option?还是说直接放 breaking changes 里

equt avatar Aug 12 '22 04:08 equt

要不要加个什么 expand-sticky 之类的 option?还是说直接放 breaking changes 里

加一个吧

07akioni avatar Aug 14 '22 14:08 07akioni

Codecov Report

Merging #3488 (2b97ddd) into main (60015b1) will decrease coverage by 0.00%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3488      +/-   ##
==========================================
- Coverage   62.99%   62.99%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       21923    21925       +2     
  Branches     5719     5720       +1     
==========================================
+ Hits        13811    13812       +1     
  Misses       6623     6623              
- Partials     1489     1490       +1     
Impacted Files Coverage Δ
src/data-table/src/DataTable.tsx 70.93% <ø> (ø)
src/data-table/src/TableParts/Body.tsx 62.98% <0.00%> (-0.23%) :arrow_down:
src/data-table/src/interface.ts 100.00% <ø> (ø)
src/data-table/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/data-table/src/use-expand.ts 61.76% <100.00%> (+1.15%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 18 '22 01:08 codecov-commenter

343d032f6ab4133e47f8d142bb6569b28403d4d3

我重新写了一下,body width 那块说明你对渲染性能还不够熟悉,可以研究一下

你那么写的话所有的情况只要 bodywidth 变了组件就会重新渲染

07akioni avatar Aug 18 '22 17:08 07akioni