Tomek Urbaszek

Maybe @myrle-krantz can help us somehow 😉

@michalslowikowski00 please rebase, I merged #78 and it introduced a lot of additional code to scan :

> @turbaszek > Have you any idea how to resolve all those conflicts? > https://github.com/apache/kibble/pull/90/checks?check_run_id=1400755394 There was missing coma, I committed it. Looks better now

Additionally when working on #94 I got the following warning. It would be good to address it: ``` /usr/local/lib/python3.8/site-packages/elasticsearch/connection/base.py:190: ElasticsearchDeprecationWarning: [types removal] Specifying types in document index requests is deprecated,...

@skekre98 sure! I did some changes in #94 around this. However what we need is to: 1. Figure out where we use this class (= where we access the database)...

Doing #114 I saw that we have also similar logic of creating es connection in: https://github.com/apache/kibble/blob/5bf37a8c0db83c918fa476a3a1b653390026e169/kibble/scanners/brokers/kibbleES.py#L286-L298

+1 for this and I think @Humbedooh also likes the type hints!

I think that if we introduce pylint #55 then we don't need flake8. We are also using black and flake8 is not always ok with black formatting - and it...

@jlrifer are you interested in continuing this work? Is there anything we can do to help you?

+1 for introducing pre-commit. It will allow us to assert code quality as a first step and then we can add tests that can also be run using this tool...