kibble-1 icon indicating copy to clipboard operation
kibble-1 copied to clipboard

Introduce Mypy in pre-commit

Open michalslowikowski00 opened this issue 4 years ago • 3 comments

Description Add Mypy in pre-commit. https://mypy.readthedocs.io/en/stable/

Use case We would like to keep our code clean and tidy -- that's why setting up Mypy in pre-commit is a good idea.

Related Issues N/A

michalslowikowski00 avatar Oct 25 '20 16:10 michalslowikowski00

+1 for this and I think @Humbedooh also likes the type hints!

turbaszek avatar Oct 25 '20 17:10 turbaszek

What do you think about flake8 also?

michalslowikowski00 avatar Oct 25 '20 17:10 michalslowikowski00

I think that if we introduce pylint #55 then we don't need flake8. We are also using black and flake8 is not always ok with black formatting - and it doesn't format the code automatically 😉

turbaszek avatar Oct 25 '20 17:10 turbaszek