Mike Tunnicliffe
Mike Tunnicliffe
I'm quite curious if initialising an express application as follows would be enough to resolve the problems. It seems to be enough to get a very simple application working (on...
OK, so the main problem I found with https://github.com/expressjs/express/issues/2761#issuecomment-216912022 is that it doesn't handle HTTP/1.1 fallback properly. Since the prototype used here is statically set to the http2 prototype, it...
I've cleaned the patch up some and changed it a bit in light of some issues that I found during further testing -- I discovered `app.request` and `app.response`, the application...
Hi @mqsoh, I'm not sure I quite understand the scenario you have. I would have expected disabling etags with `app.disable('etag');` to result in responses with `fresh` being true and therefore...
OK, what are they doing? Is there some middleware or route handler is setting the 'ETag' header, rather than relying on Express to do it, or setting the etag function...
OK, that sounds reasonable to me.
Some suggestions: "send not modified" "send unchanged" "send unaltered"
Related to #2524
One thing I'm not sure on is the whether a "views" value of "/a" should be considered different to "/a/" or "/a/b/.." etc. The PR assumes the conservative position that...
This will need modifying to address the "special" options 'etag', 'query parser' and 'trust proxy'. See https://github.com/expressjs/express/blob/5.0/lib/application.js#L357