triage-new-issues icon indicating copy to clipboard operation
triage-new-issues copied to clipboard

Published 20 hours ago • verified publisher icon tunnckoCore

Unable to customize label

Open stalgiag opened this issue 5 years ago • 6 comments

Hello!

I am trying to configure this bot on the p5.js repo and I am unable to customize the label that is added. As far as I can tell, our triage.yml is setup correctly but we are still getting the triage label every time.

Any advice or insight would be very appreciated. Thanks for your work!

stalgiag avatar Dec 17 '19 20:12 stalgiag

Perhaps related to the hyphens in our desired custom label and #41 ?

stalgiag avatar Dec 17 '19 20:12 stalgiag

Thanks for the report. I'll check.

tunnckoCore avatar Dec 18 '19 05:12 tunnckoCore

Hmm.. Sounds like some bug, but I'm not sure. It shouldn't be the hyphens. Probably some config resolving problem.

The other problem is that the deployment is on Now v1 and for some reason can't access the logs ;/ @styfle any ideas?

2019-12-18-072225_1280x1024_scrot 2019-12-18-071953_1280x1024_scrot

I'm not sure if will be able to upgrade it, debug and update it, because I'm out in tomorrow morning until january. So PRs and ideas are welcome, I'll be able to review and merge (but not sure if I have automated release/publish/deploy flow here).

Not to mention migartion won't be just moving the src/index to api/index. @gr2m @zeke, ideas on migating Probot Apps to Serverless Now v2? Does @probot/serverless-lambda will work for it? (as I remember Now is on AWS :thinking: )

@stalgiag, alternatively this looks good https://probot.github.io/apps/pr-triage.

tunnckoCore avatar Dec 18 '19 05:12 tunnckoCore

Thank you for looking into it @tunnckoCore !

I am not sure if that PR triage bot that you linked will work for our needs since we are more concerned with making sure that issues are labeled. This isn't super high priority though so we can uninstall the bot and try again in the future if a fix is found.

stalgiag avatar Dec 18 '19 16:12 stalgiag

@gr2m @zeke, ideas on migating Probot Apps to Serverless Now v2? Does @probot/serverless-lambda will work for it? (as I remember Now is on AWS 🤔 )

It's something I want to focus on for the next Probot version, but cannot give you an ETA.

Maybe check https://github.com/probot/serverless-lambda for the time being?

GitHub
An extension for running Probot on Lambda. Contribute to probot/serverless-lambda development by creating an account on GitHub.

gr2m avatar Dec 19 '19 18:12 gr2m

I created a PR here: https://github.com/tibdex/probot-serverless-now/pull/11

I didn't know there was an official serverless option, I'll have to check that out 👍

styfle avatar Dec 19 '19 20:12 styfle