Joe Schmetzer
Joe Schmetzer
I really like they way that this simplifies the calling code for collections of items. Without knowing if this is true, I also worry that this will break other code...
I agree with @brownian-motion, the test works for me if I include the explicit types (which is ugly). I'm afraid I don't have any better advice than to swear at...
Hi @Tikani, the project is still alive. I'm afraid the last few months have been quite overwhelming for me personally, so I haven't had much time to look at this....
Hmm... looking closer at this issue: the change was introduced in issue #40, with the justification that it followed the [Guidelines for Wildcard Use](https://docs.oracle.com/javase/tutorial/java/generics/wildcardGuidelines.html). Looking at the example you provided,...
Yeah, reading that page more carefully, it explicitly says: > These guidelines do not apply to a method's return type. Using a wildcard as a return type should be avoided...
This seems like a nice improvement, but I'm afraid the [Travis CI build failed](https://travis-ci.org/hamcrest/JavaHamcrest/builds/548227522). Can you fix that issue?
I just had a look at implementation of [`IsMapContaining.hasKey(K key)`](https://github.com/hamcrest/JavaHamcrest/blob/master/hamcrest/src/main/java/org/hamcrest/collection/IsMapContaining.java#L100). I get the impression that the current implementation is the way it is because of simplicity and consistency. That method...
Understood. Are you able to submit a PR?
This change seems like an improvement. @PirolA, can you add a test for the changed functionality to this PR?
This seems like a reasonable improvement, though issues #206 and #207 will have to be resolved first, as `Supplier` is a 1.8 functional interface.