Liren Tu

Results 8 comments of Liren Tu

I propose to add a `@Deprecation` annotation to the `selectAgg` method. Users can use `GenericQuery` instead.

@qstearns saw a related issue. The [`process_model`](https://github.com/LiveRamp/jack/blob/master/jack-core/src/rb/models_dir_processor.rb#L35) method is supposed to ignore associations with `through` keyword. In [`parse_associations `](https://github.com/LiveRamp/jack/blob/master/jack-core/src/rb/models_dir_processor.rb#L53): ```ruby if not_matches matching_lines = matching_lines.reject { |l| l =~ /^\s*#{not_matches}/...

@roshan, thank you for the suggestion. Would you like to give it a try and create a PR? 😏

We should not use commons pool2 `2.4.3` because it introduced `ScheduledThreadPoolExecutor` in the `EvictionTimer`, and it will cause the workflow to hung indefinitely. Basically don't upgrade to any version that...

FYI a new version for MySQL and MSSQL is being published [here](https://github.com/airbytehq/airbyte/pull/15538). Should be done in the next hour.

> The build was triggered when you reviewed, right? Yes, I approved the action on that PR, and the action did run. It's probably a permission issue from the GITHUB_TOKEN.

The table in table on the left is a bit weird.