Turiiya

Results 229 comments of Turiiya

I think so too that a dynamic number of custom fields would exemplify good design. > [...] If I'm right in saying custom fields are just stored as an array...

Hey @PoTaTo-Mika thanks for taking care of this. `cachetools` is actually there: https://github.com/fishaudio/fish-speech/blob/b11bcf834a97a75073b535838e5f0765f169eb94/pyproject.toml#L49 Should it just be pinned then? Maybe it can be done in a separate commit since the...

With a fix the asserts in the added test can be enabled https://github.com/webui-dev/webui/blob/6cefcb1f3d2f1b5f2d1573b0dc3f42fcd3ce2578/tests/call_c_from_js.c#L36-L51

Happens in chrome and Firefox for me. Logs `call_c_from_js` example: ``` [User] webui_new_window() [User] webui_get_new_window_id() [Core] WebUI v2.5.0-beta.1 (GNU/Linux, GCC, Non-Encrypted) [Core] _webui_init() [Core] _webui_get_current_path() [Core] _webui_malloc([4096]) [Core] _webui_ptr_add(0x0x5c0f4c35d6b0) [Core]...

I see it doesn't reproduces in CI (asserts for floats are currently commented out, values are only printed): JS passed: ```javascript await webui.assert_float(1.0, 2.3, 3.45); ``` backed prints: ``` num1:...

The get_string call doesn't look right: ``` [User] webui_get_float_at([3]) [User] webui_get_string_at([3]) ``` The example is unchanged ofc.

> ``` > [Core] _webui_process(2) -> Argument 0: 3 bytes > [Core] _webui_process(2) -> Argument 1: 3 bytes > [Core] _webui_process(2) -> Argument 2: 3 bytes > [Core] _webui_process(2) ->...

Yep the check failed, tested with atof/strtod/sscanf. The conversion works correctly when `setlocale(LC_NUMERIC, "C");` is set. Then the assert works with the fully specified number: ```c assert(num3 == 3.450000); //...

The recent path completion has been completely broken for a few months. I've been holding on to an earlier commit ever since. Cd into your zsh-autocomplete plugin/submodule path and ```...