fish-speech icon indicating copy to clipboard operation
fish-speech copied to clipboard

Remove dependency duplicate

Open ttytm opened this issue 1 year ago • 2 comments

The PR removes a dependency duplicate that caused some issues getting started when I was using a conda/pypi derivative.

Below I'm linking the the current dates latest ref for quick access. The first and last line show the dupl https://github.com/fishaudio/fish-speech/blob/b11bcf834a97a75073b535838e5f0765f169eb94/pyproject.toml#L22-L33

ttytm avatar Dec 08 '24 11:12 ttytm

Hi, would you please add "cachetools" library into it? This will be helpful as we forgot to update the pyproject.toml. Please pin it to 5.3.1, thanks a lot for your contribution to the repo :)

PoTaTo-Mika avatar Dec 09 '24 09:12 PoTaTo-Mika

Hey @PoTaTo-Mika thanks for taking care of this.

cachetools is actually there: https://github.com/fishaudio/fish-speech/blob/b11bcf834a97a75073b535838e5f0765f169eb94/pyproject.toml#L49

Should it just be pinned then? Maybe it can be done in a separate commit since the changes can be classified as standing on their own.

ttytm avatar Dec 09 '24 09:12 ttytm