Tyler Waters

Results 50 comments of Tyler Waters

this _seems_ to work: ``` js const app = express() const http = require('http').Server(app) const io = require('socket.io')(http) i18n.configure({ locales: ['en', 'de'], directory: `${__dirname}/locales` }) app.use(i18n.init) io.on('connection', (socket) => {...

> Should that be `/^data-/` ? Yes... yes it should. This approach in general is a good call. I found that when the change applied to all engines, hypertext promptly...

fwiw, that's *basically* what the PR does, but it puts it behind a flag so the library can handle it for users in a consistent manner. If consumers do need...

Interesting... in https://github.com/substack/hyperx/pull/16 a test was added with data-\* attributes, but I think the only reason this test is passing is because toString in min-document includes stray data-\* attributes in...

Sorry for all the noise there, pushed up some force commits after I noticed some errors... The PR has been adjusted to use a flag, `{vdom: true}` - this will...

If someone is looking for a catch behaviour, you can pull out the error from state and throw if it exists.... something like the following should work. This tosses the...

I've done a bit more digging on this. When the common chunks plugin is in play, the single promise resolution for the `System.import` turns into a `Promise.all`, as it loads...

This requires a change of the API -- and not using middleware at all! Before: ```js createStore( combineReducers({....}), initialState, applyMiddleware(...[thunk, etc, logger]) ) ``` After ```js createStore( logger(combineReducers({....})), initialState, applyMiddleware(...[thunk,...

> the problem was how redux middleware works. Middleware functions just change dispatch. It just so happens to be a really good injection point for logging. [Calling `next` on the...

Noticed this as well. We use the `authenticateHandler` for the login form that shows up on the authorization server, for auth code flow.... something like this: ```js app.post('/login', async handler(req,...