Tsuyoshi Yoshizawa

Results 14 comments of Tsuyoshi Yoshizawa

This commit has broken compatibility. https://github.com/playframework/playframework/commit/f453ddabb196966c74e743d27cc5765716f6e73f It has been released in 2.8.6. My project also had a compile error after upgrade the version. I modified the project code to fix...

We expect that `AccessToken` use only one instance for one request coming. The access token is created when user authorize via OAuth server first. With the created access token, `expiresIn`...

> If `AccessToken` has to be reissued upon each request, what's the use of methods such as `getStoredAccessToken` or even the logic to refresh it? We expect that `getStoredAccessToken` is...

@fg-devs Thank you for your PR! I would choose No.1 solution. No.2 solution looks like Scala and feels very extensible. But I'm not sure if `AuthInfo` is required to be...

Hi @fg-devs, @rmmeans pointed out in the above comment. Certainly, as he says, my project solved it in the same way. What do you think?

Thank you. I understand your opinion. I have a question by watching the PR code carefully. Do you create the `AuthInfo` by accessing from some datastore? `AuthorizationHandler` designs to fetch...

I think to support the authorization for WebSocket is good. Play `Websocket` supports to return a future of either by `tryAcceptWithActor` The method requires `Future[Either[Result, HandlerProps]]` to result of callback....

> do you think we should still add support for this feature to the play-2.2.x version? I don't think to add support except a critical bug to the play-2.2.x version....

I'm going to try this feature after release version 0.9.0 and 0.7.4.

> So, providing something like this would be great. I think you directly use `ProtectedResource` in your controller for handling an error response is better. Because it just calls `ProtectedResource.handleRequest`...