Tihomir Surdilovic

Results 171 comments of Tihomir Surdilovic

the schemas in the spec are the source of truth what should be changed is that schema validation should use the schemas deployed on our website rather then internal: https://github.com/serverlessworkflow/sdk-java/blob/main/api/src/main/java/io/serverlessworkflow/api/validation/WorkflowSchemaLoader.java#L28...

@fjtirado if you think we can improve the generation to use the spec schemas that sounds nice, maybe you can start this work in a separate branch and let's see...

we are going to move schema validation to use spec schemas rather than the sdk ones, so these things i think won't be as big of an issue

the "non-generated" ones should be base classes only. maybe lets open a proposal for changes you want to do (open as issue if you want) and lets see what you...

> @tsurdilo ok, whats exactly the plan? Currently the generated POJOS in the SDK already has the javax.annotations. The not generated ones does not. I am not 100%. sure right...

thanks for pr. will run some tests on it

That would rock. Yes, let's figure out what's missing/can be improved and add it. Some work on TCK and conformance has started there but still early stage. Seem to be...

Can set this to false in docker compose yml - "SKIP_DEFAULT_NAMESPACE_CREATION=true"

possibly related issue https://github.com/temporalio/ui/issues/943

Just adding another user request for this from community slack: https://temporalio.slack.com/archives/CTRCR8RBP/p1671459009541329 @stevekinney @feedmeapples do you happen to know if this is in a release plan? Thanks