sdk-java icon indicating copy to clipboard operation
sdk-java copied to clipboard

#225 Update to Jakarta

Open radtriste opened this issue 1 year ago • 7 comments

Many thanks for submitting your Pull Request :heart:!

https://github.com/serverlessworkflow/sdk-java/issues/225

What this PR does / why we need it: With Jakarta introduced into Spring Boot and Quarkus 3, there is a need for projects to support Jakarta.

Special notes for reviewers: I am not sure how to handle that. Should we have *-jakarta modules of the sdk ? or a different version ?

Additional information (if needed):

radtriste avatar May 05 '23 12:05 radtriste

thanks for pr. will run some tests on it

tsurdilo avatar May 09 '23 12:05 tsurdilo

@radtriste can you please rebase it?

ricardozanini avatar Oct 11 '23 17:10 ricardozanini

@manick02 do you mind taking a look? @radtriste sorry, can you rebase again? 🙏

ricardozanini avatar Oct 17 '23 19:10 ricardozanini

Looks good to me, apart from a minor nit

manick02 avatar Oct 18 '23 02:10 manick02

@manick02 @ricardozanini all updated

radtriste avatar Oct 20 '23 11:10 radtriste

I'll rebase and include this in a follow up 4.1.0 release supporting Java 11 and Jakarta. @manick02 @fjtirado @cdavernas wdyt?

ricardozanini avatar Oct 20 '23 14:10 ricardozanini

Ok

manick02 avatar Oct 21 '23 05:10 manick02