Tom Shen

Results 16 issues of Tom Shen

In https://github.com/arkworks-rs/algebra/blob/bf1e24211df2be1ee317e382aa128281766e9c1f/ff/src/biginteger/mod.rs#L1029-L1040 Is this documentation a typo? Should it be "a **little** endian integer" instead of "a big endian integer"? @Pratyush

∂ ## Summary of Bug Currently, `ConstraintLayer` does not implement `tracing-subscriber::Layer` trait in v0.3 (so it will not work). Do we want to update this dependency? https://github.com/arkworks-rs/snark/blob/7af2b44215b09fda4f41813e274ad9464381711e/relations/Cargo.toml#L19-L20 ```diff - tracing-subscriber...

in `r1cs` crate: I believe it is better to add a circuit generator with configurable number of instance variables, number of witness variables, sparsity, and random source. So, when user...

https://github.com/scipr-lab/libiop/blob/a2ed2ec2f3e85f29b6035951553b02cb737c817a/libiop/protocols/encoded/sumcheck/sumcheck.tcc#L367-L381 Here, `actual_sum` should be `g[0] * this->summation_domain_size` instead of `g[0]`. Please see https://github.com/arkworks-rs/bcs/blob/2ddd1db3838cbf393a8d8d7eafe6a004aa584c61/sumcheck/src/util.rs#L16-L27 for a possible fix

## Summary Add allocator for `DensePolynomialVar`, so we can easily convert `ark_poly::DensePolynomial` to `DensePolynomialVar` by calling `DensePolynomial::new_variable`. We can keep release 3.0 as is. It's ok to move this feature...

T-feature
D-easy

## Description Add Cryptographic hash function trait, and proof of work. closes: #74 blocking: arkworks-rs/bcs#2 (currently is a private repo) --- Before we can merge this PR, please make sure...

Looks that arkworks does not have the implementation of proof of work (even the simplest one). We can probably add one here (use the one similar to [`libiop`](https://github.com/scipr-lab/libiop/blob/master/libiop/bcs/pow.tcc#L73-L84)? ) We...

https://github.com/arkworks-rs/crypto-primitives/blob/1a71386a10ef627834e4c3b14ca982811f23192d/src/crh/constraints.rs#L9-L25 Is there any circumstance where user compute CRH parameters in circuit? Computing `ParametersVar` requires extra constraints so it should be better to allow an option to use native CRH...

T-design
T-refactor
P-low
D-medium

## Summary Move https://github.com/arkworks-rs/poly-commit/blob/04e1e5db1f0983d9d1cb7f022703af2d976f69f2/src/challenge.rs to here, because there are applications other than `poly-commit` needs this generator. ____ #### For Admin Use - [x] Not duplicate issue - [x] Appropriate labels...

T-feature

Add default parameters of Poseidon Sponge for common curves (bls12, mnt4)