Toshinori Tsugita comments

Results 8 comments of


                                            Toshinori Tsugita

Support request-scoped, global enhancers

@jmcdo29 the code works, but it looks like `const contextId = ContextIdFactory.getByRequest(req);` always generates new ID because `req[REQUEST_CONTEXT_ID]` isn't set. ref: - https://github.com/nestjs/nest/blob/d1d1a16eb4ce2e30151fe5bdefa0a3e2c084b43e/packages/core/helpers/context-id-factory.ts#L28-L42 - https://github.com/nestjs/graphql/blob/90ae4e878b07e008fcaf8f9bf7a840e883e0bcaa/packages/graphql/lib/services/resolvers-explorer.service.ts#L186 therefore, the request-scoped service may...

Fragment cache somtimes returns null despite cached data loading initially

@gsdean same here, can you explain how the workaround works? I understand the problem derives from fetching cache multiple times, but is it safe to fetch cache multiple times in...

Fragment cache somtimes returns null despite cached data loading initially

> If I understand correctly, the problem is that race condition makes cache to return nil even if it's not nil anymore. in my situation, the problem seems that race...

Fragment cache somtimes returns null despite cached data loading initially

I'm not familiar with the cache API or instrumentation API, but it seems that the `read` method records whether or not there is a cache hit, so by using it,...

Fragment cache somtimes returns null despite cached data loading initially

> The problem I'm trying to solve is that read returns nil in either when there's no such key at all (so we need to run the resolver method) and...

Fragment cache somtimes returns null despite cached data loading initially

I had overlooked that the version I was using was outdated. After upgrading this library from `1.9.1` to `1.18.1` (and Rails from `6.1.4.4` to `7.0.4`), this problem, which used to...

Multiple `@JoinColumn` with same `name` interferes with each other

I guess the problem is caused by that the column instance's `referencedColumn` is overridden below: https://github.com/typeorm/typeorm/blob/a909d5b6975f0feb0c8759dd146dba8f1e3ad168/src/metadata-builder/RelationJoinColumnBuilder.ts#L237 To resolve this, I think it's necessary or natural to have multiple referencedColumn as...

Multiple `@JoinColumn` with same `name` interferes with each other

Using the same `referencedColumnName` seems the only workaround for now, meaning the property names should be identical. By using the name option like `@Column({ name: 'foo' })`, we can keep...