Thomas Stuefe

Results 110 comments of Thomas Stuefe

I don't have time to review this, but kudos for clearly delineating and explaining the delta between this patch and its original. Wish every backporter would do this.

Hi Goetz, This is the same logic behind Maria's attempt to port NMT changes to 11, which you blocked. We did not explicitly talk about 17. If you, as maintainer,...

Hi Robert, what's wrong with the red GHA tests? Besides that, please make sure, especially for a PR that has been dormant for a longer time, that you merge in...

Please look at the test errors in GHAs and check them. Provided they have nothing to do with the patch, my approval still stands.

All test errors stem from the fact that we call the JVM with a very small MaxMetaspaceSize, and the CCS size - which is set to 80% of MaxMetaspaceSize -...

Okay, I now just require the max encoding range to be at least the size of a root chunk (16 MB) and otherwise revert the behavior to before, meaning we...