8289182: NMT: MemTracker::baseline should return void

[Delawen]

This backport does not introduce any new feature or bug fixing, but it removes dead code. Before the backport, MemTracker::baseline() always returned true. Now, it returns void and all the conditionals that depended on that result are simplified.

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8289182 needs maintainer approval

Issue

• JDK-8289182: NMT: MemTracker::baseline should return void (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2415/head:pull/2415
$ git checkout pull/2415

Update a local copy of the PR:
$ git checkout pull/2415
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2415

View PR using the GUI difftool:
$ git pr show -t 2415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2415.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back Delawen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@Delawen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289182: NMT: MemTracker::baseline should return void

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

• e85eecbea09e68fcac68a39901a58ddf41fa9dbd: 8288568: Reduce runtime of java.security microbenchmarks
• 2d834b36ec68890befc21d93b667d07cbf3c007a: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
• 787cf27a8bb19c58bfa5bd17bf433ddaa99117d7: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"
• 24aa1e1f1835c83cbf5cfeda56186511a3bd0100: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
• cc3f0e52bfee9d96c464ae55999e834717aa3772: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
• 1ead7a7fdeb6ddbbe3ad0896b7d492929ef9b7a3: 8331265: Bump update version for OpenJDK: jdk-17.0.13
• c9d83d392f3809bf536afdcb52142ee6916acff0: 8325203: System.exit(0) kills the launched 3rd party application
• 0cfee92c2974aaf8fe387e3393702e58c2917f18: 8294699: Launcher causes lingering busy cursor
• f4da0e7a58261a25ca11783c62f4a6f53718103e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• d1e31f6f6a455572c2d5b6f118ce54fa040e0e82: 8289643: File descriptor leak with ProcessBuilder.startPipeline
• ... and 87 more: https://git.openjdk.org/jdk17u-dev/compare/290fb644baf033dac21bd3935ff6dc1e9b27de3d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[openjdk[bot]]

⚠️ @Delawen This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge[bot]]

Webrevs

• 00: Full (604ce4c1)

[Delawen]

/approval JDK-8289182 request Fix Request This backport does not introduce any new feature or bug fixing, but it simplifies the source code. Before the backport, MemTracker::baseline() always returned true. Now, it returns void and all the conditionals that depended on that result are simplified.

[openjdk[bot]]

@Delawen JDK-8289182: The approval request has been created successfully.

[GoeLin]

Hi @Delawen, @tstuefe why do we need this in 17? Probably there is a follow up you want to backport?

[Delawen]

why do we need this in 17?

I was reviewing the pending backports and realized this is a very simple boyscoutting task that simplifies the code. To me it made sense to keep the code clean and simpler for maintenance.

[tstuefe]

Hi Goetz,

This is the same logic behind Maria's attempt to port NMT changes to 11, which you blocked. We did not explicitly talk about 17. If you, as maintainer, feel 17 should be feature stable and we should not downport NMT changes, then that is fine with us. In that case, we would abort the attempt to downport any missing NMT changes.

[GoeLin]

Hi @tstuefe, I think there can be good reasons to backport NMT changes as they can improve analysing issues in 17. But there should always be a reason for each backport. There should be something 17 profits from. I would assume you have a follow-up that is easier to backport if this one is in?

[bridgekeeper[bot]]

@Delawen This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheRealMDoerr]

This one is ready for integration. Another PR is waiting for it.

[Delawen]

Ok :)

[Delawen]

/integrate

[openjdk[bot]]

@Delawen Your change (at version 604ce4c1d7f62f58d4eef45e4e152c8562ec5d2e) is now ready to be sponsored by a Committer.

[tstuefe]

/sponsor

[openjdk[bot]]

Going to push as commit 8faeefc1509a5b890bdae852472c318c64dc0772. Since your change was applied there have been 97 commits pushed to the master branch:

• e85eecbea09e68fcac68a39901a58ddf41fa9dbd: 8288568: Reduce runtime of java.security microbenchmarks
• 2d834b36ec68890befc21d93b667d07cbf3c007a: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
• 787cf27a8bb19c58bfa5bd17bf433ddaa99117d7: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"
• 24aa1e1f1835c83cbf5cfeda56186511a3bd0100: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
• cc3f0e52bfee9d96c464ae55999e834717aa3772: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
• 1ead7a7fdeb6ddbbe3ad0896b7d492929ef9b7a3: 8331265: Bump update version for OpenJDK: jdk-17.0.13
• c9d83d392f3809bf536afdcb52142ee6916acff0: 8325203: System.exit(0) kills the launched 3rd party application
• 0cfee92c2974aaf8fe387e3393702e58c2917f18: 8294699: Launcher causes lingering busy cursor
• f4da0e7a58261a25ca11783c62f4a6f53718103e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• d1e31f6f6a455572c2d5b6f118ce54fa040e0e82: 8289643: File descriptor leak with ProcessBuilder.startPipeline
• ... and 87 more: https://git.openjdk.org/jdk17u-dev/compare/290fb644baf033dac21bd3935ff6dc1e9b27de3d...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@tstuefe @Delawen Pushed as commit 8faeefc1509a5b890bdae852472c318c64dc0772.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.