tstadel

JSON structures are not really common for python frameworks, most of them just use python's logging lib (e.g. tranformers, pytorch, elasticsearch python client). Using structlog seems not be the right...

To answer the questions above: > - is there some information missing to show? - some basic latency/performance measures or node-entering events can improve transparency and > - is there...

@ZanSara and @lalitpagaria It's been this discussion [here](https://github.com/deepset-ai/haystack/discussions/1884) I think. Seems like you could use SQL-syntax to query table-files like CSV. So this could be a feature of SQLDocumentStore. However...

Removing `return_embedding` from `get_document` is fine for now. In the future we might support that in all document stores: https://github.com/deepset-ai/haystack/issues/3007. Currently it's just confusing as it has no effect.

> - Up for discussion: Should standard_pipelines.eval and standard_pipelines.eval_batch have a documents parameter that they pass on? I think it's fine to not have them here, as they are only...

@Pavithree do you use the same `sql_url` in both cases? Do you use a persistent SQL database? `FAISSDocumentStore` uses two separate databases (FAISS index for vectors and SQL for document...

@FHardow the second checked point should result in a proper `EvaluationResult` object being returned. This is just a container around the dataframes with additional functionality like `calculate_metrics`, etc.

@wochinge if there is no index yet how should the code infer whether the embedding field supports the requested similarity type? In your case you know that the embedding field...

Ah sorry, I missed it's not even set when creating the index. Will fix that, however supporting custom_mappings will be slightly more complicated. Probably it makes sense to separate the...

@sjrl I think it's not really solving it as this would only fix the eval() and eval_on_file() methods but not `FARMReader`'s `predict()`.