tobi

Results 592 comments of tobi

@mirabilos I believe that's the second or third time in this thread now that you've suggested the same thing. The point has been taken already.

> the issue has managed to come up again Ah that's a pity. I'm not sure what else could be done at this point, though this will be alleviated somewhat...

Alright, looks good to me :) I think @daenney might want to have a look over this since it pertains to other OIDC stuff that he's worked on.

If you could add some small tests for the `allowedGroup` and `adminGroup` functions, this will be ready to squerge I think :) Do you need any help writing the tests?

Ah thanks for opening this :) Will likely be something for early next year!

We're gonna work on this after 0.14.0 is out :) It's not too tricky to implement, by the looks of it. So probably be included in 0.15.0 whenever we get...

Ah thanks, I actually noticed that during development and thought "I'll fix this later". Hello, consequences of my actions.

I fixed this recently, I can't remember in what PR but it is fixed on main at least :')