Thomas Mäder

Results 214 comments of Thomas Mäder

@JonasHelming probably a good idea if you have a look over the changes I made to make the tests pass.

@sdirix, @msujew , @JonasHelming and @tsmaeder had a discussion about this and here's a couple of results: * Moving to ESM would be a breaking change for our adopters: not...

Note that the window remains open in the "SecondaryWindow" section in the "Open Editors" view. When clicking the close button in the "Open Editors" view, the file can be opened...

Turns out we just never call `ApplicationShell.closeWidget()` in the browser case. The call got lost in the refactoring to enable secondary windows in electron.

Hi @wss29 the only way this seems possible if one of these things happen: 1. The message that notifies about the new run profile overtakes the message that registers the...

@rschnekenbu this API is not marked as stubbed, that's why it does not appear on the comparator output. Can we put this on the backlog for API-compat?

As far as I can see, VS Code is also using the same approach of just moving the html to a different window, just like we did it for the...

A little experimenting shows that the CSS does not get loaded properly when an editor is moved to a secondary window. The problem seems to be that we're missing a...

Extending our current "external window" support to text editors would entail (IMO) 1. Coming up with a contribution point that allows contributors to hook into the process of moving the...