theia
theia copied to clipboard
Remove git Theia extension from examples
related to #12745
What it does
Removes the Theia git extension from the example applications to prepare the deprecation (see #12745)
How to test
Build the examples, they should not include the Git Theia extension anymore.
Review checklist
- [x] As an author, I have thoroughly tested my changes and carefully followed the review guidelines
Reminder for reviewers
- As a reviewer, I agree to behave in accordance with the review guidelines
Absolutly, where is the exclude defined?
@JonasHelming These two entries in particular:
https://github.com/eclipse-theia/theia/blob/a6d7e9b6250a14e008477436fe97592761525776/package.json#L114-L115
Thanks, I tested git in the example app (browser) and it showed correctly for me (the VS Code built-in)
The changes look good, but for some reason the browser tests fail. Do they somehow rely on the @theia/git
extension?
I'm having a look at this: likely, the difference is that the git extension is not automatically detecting git repos rooted in parent folders.
The typescript test fail because of the update to 1.88.1 of the built-in extensions. Once we have merged https://github.com/eclipse-theia/theia/pull/13673, they should pass.
@tsmaeder Looks good to me, could you approve it?
@JonasHelming probably a good idea if you have a look over the changes I made to make the tests pass.