theia icon indicating copy to clipboard operation
theia copied to clipboard

Remove git Theia extension from examples

Open JonasHelming opened this issue 1 year ago • 4 comments

related to #12745

What it does

Removes the Theia git extension from the example applications to prepare the deprecation (see #12745)

How to test

Build the examples, they should not include the Git Theia extension anymore.

Review checklist

Reminder for reviewers

JonasHelming avatar Jan 16 '24 10:01 JonasHelming

Absolutly, where is the exclude defined?

JonasHelming avatar Jan 16 '24 12:01 JonasHelming

@JonasHelming These two entries in particular:

https://github.com/eclipse-theia/theia/blob/a6d7e9b6250a14e008477436fe97592761525776/package.json#L114-L115

msujew avatar Jan 16 '24 13:01 msujew

Thanks, I tested git in the example app (browser) and it showed correctly for me (the VS Code built-in)

JonasHelming avatar Jan 16 '24 15:01 JonasHelming

The changes look good, but for some reason the browser tests fail. Do they somehow rely on the @theia/git extension?

msujew avatar Jan 23 '24 13:01 msujew

I'm having a look at this: likely, the difference is that the git extension is not automatically detecting git repos rooted in parent folders.

tsmaeder avatar May 02 '24 07:05 tsmaeder

The typescript test fail because of the update to 1.88.1 of the built-in extensions. Once we have merged https://github.com/eclipse-theia/theia/pull/13673, they should pass.

tsmaeder avatar May 05 '24 10:05 tsmaeder

@tsmaeder Looks good to me, could you approve it?

JonasHelming avatar May 05 '24 17:05 JonasHelming

@JonasHelming probably a good idea if you have a look over the changes I made to make the tests pass.

tsmaeder avatar May 07 '24 13:05 tsmaeder