Matthieu Stockbauer
Matthieu Stockbauer
Hello, this PR is ready for in-depth review, could you please help me with that ? Thanks in advance ! @antonylesuisse, @odony, @rco-odoo, @Julien00859, @seb-odoo, @sdegueldre cc: @LucasLefevre, @amigrave, @nim-odoo
@xmo-odoo > Q: this seems to remove the longpoling route entirely, does the new websocket code still leverage gevent or not? Yes it does, else we would have 1 thread...
@xmo-odoo, Thanks for your review, I applied your suggestions. Notable changes are: - Lifecycle callbacks must be non-member functions - select.select is replaced by selectors - /longpolling/XXX routes are now...
Hello @qsm-odoo, I pushed the PR after making changes: the `persisted` property of the `pagehide` event is checked before disconnecting from the worker. As for the `presence/multi_tab` case, I believe...
Hello @qsm-odoo, this notif is trigerred by the bus service when the websocket connection is lost, so this PR won't solve the problem. As for the 15.0 case, the poll...
Hello @AntoineVDV, could I please have your review on this ? Thanks :+1:
@robodoo rebase-ff
> Small issue I noticed when testing: > > * going from chat window to discuss keeps the separator, but going back to chat window loses it > * (in...
@alexkuhn Regarding https://github.com/odoo/odoo/pull/159352#discussion_r1570925664, There is no `markAsRead()` split everywhere in the code; it's as simple as that: when users actively open a thread, we mark the thread as read. Yes,...