Nikolaos Tsantalis

Results 74 comments of Nikolaos Tsantalis

@pouryafard75 According to Eclipse JDT documentation [getTagName](https://help.eclipse.org/latest/topic/org.eclipse.jdt.doc.isv/reference/api/org/eclipse/jdt/core/dom/AbstractTagElement.html#getTagName()) Returns this node's tag name, or `null` if none. So, this a property of the `TagElement` ``` CompilationUnit [0,30] TypeDeclaration [0,30] Javadoc [0,19]...

@pouryafard75 We can check if [getTagName](https://help.eclipse.org/latest/topic/org.eclipse.jdt.doc.isv/reference/api/org/eclipse/jdt/core/dom/AbstractTagElement.html#getTagName()) returns something, and if not we can check the `optionalTagName` property. We will use `TagName` as the label for this kind of nodes. @jrfaller...

@pouryafard75 Is it a convention to use upper case names for AST node properties? `TAG_NAME` `TYPE_DECLARATION_KIND`

@pouryafard75 Thank you! I have a question about `findMostInnerEnclosingParent()` In case the comment is within a statement as follows, does `findMostInnerEnclosingParent()` return the `return` statement as parent, or the expressions...

OK, I think it makes sense to have it like that from the AST point of view. RefactoringMiner keeps all comments in the parent method declaration, but this is more...

@jrfaller I reviewed the PR and it is ready to be merged. It would be a nice feature for version 4 to support inline comments.

@jrfaller @pouryafard75 I agree comments should be diffed by default. We don't need this boolean in the constructor. Comment diff is a very important missing feature.

@pouryafard75 None of the comments given by `CompilationUnit.getCommentList` has a parent. All of them are detached from the AST. Some of them could be actual javadocs of methods, classes, fields,...

@pouryafard75 Yes you are right. The attached javadocs to method, field, type declarations have a parent, while those inside method bodies have a `null` parent. Your PR is extensively tested...

@monperrus Martin, thanks for the pointer. We will check if it is possible to add gumtree-spoon in our AST diff benchmark.