Nikolaos Tsantalis
Nikolaos Tsantalis
This is a rather rare scenario, which would take a lot of effort to implement. Supporting the matching of conditional expressions with if statements is interesting though.
The functionality is already there https://github.com/tsantalis/RefactoringMiner#with-two-directories-containing-java-source-code We just need an API for it. Go ahead with the feature and I will merge it.
@mkshiblu We don't support yet the move of code between the initializer blocks of different classes. In my opinion, it does not make much sense to support it. Initializer blocks...
This is a duplicate with #253 related to sub-expression matching
@mkshiblu I think the reason is that you have two variables (`fnText` and `args`) declared in the same statement. ```java StringVar fnText = Function.prototype.toString.call(fn).replace(STRIP_COMMENTS, ""), args = fnText.match(ARROW_ARG).match(FN_ARGS); ```
In this case `String name = "A";` is matched with `return "A";` instead of `return name;` -> `return "A";` + Inline Variable `String name = "A";` A similar scenario for...
There is an even newer release https://mvnrepository.com/artifact/com.github.tsantalis/refactoring-miner/2.2.0
@pouryafard75 In introduced sub-expression mappings instead of a CompositeReplacement with additionally matched statements, because in the second case the `add` method call names were matched with `containsNoDuplicates` ![Screenshot from 2023-04-10...
Based on the diff, I think `testUtil.waitFor(60000, 250, new ExplainingPredicate() {` is now executing the same code in a loop, so the `while` loop is not needed any more. So,...
@victorgveloso Based on the analysis I did above, I think the Invert Condition is not a False positive.