Taylor Salo
Taylor Salo
Scikit-learn has a template for extensions, [`scikit-learn-contrib/project-template`](https://github.com/scikit-learn-contrib/project-template). The approach seems to involve creating estimators, for which there is both documentation and a `check_estimator` test. I didn't see any information on...
I think we probably need a checklist of requirements for algorithms that _should_ be merged, in addition to requirements for mergeable code. Some possible requirements for mergeable algorithms: - Associated...
Thanks for looking into it @JulioAPeraza! Do you think it's worth it to maintain the Docker image? I feel like it might be unnecessary now that NiMARE's written purely in...
In that case, I will remove the image on DockerHub. We will need to update the Dockerfile though. It looks like it still installs MALLET, for example- not to mention...
If we're going to keep the Dockerfile, I think we should probably add a CI test that uses it, if possible. That way we'll at least get some indication that...
I started drafting an Annotation class and realized a couple of things: 1. If we want topic-voxel arrays for GCLDA, then we need a masker object for mapping from images...
Also, for the `to_filename` method, I realized that just saving a TSV/CSV file wouldn't include the metadata we need for topic-based annotations. Should it also save an associated JSON file...
I'm starting to worry that storing a Studyset's annotations as a single attribute, with individual analyses linked by IDs across annotations and other attributes, will be a problem for NIMADS...
Are there any other cases that anyone can think of where we can move methods to functions?
@mriedel56 @62442katieb if possible, I'd love it if you could check out the new class (especially the `_fit` method, which does the actual CBP) and give your thoughts. So far,...